Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitUtils.cmake #3939

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Update GitUtils.cmake #3939

merged 1 commit into from
Dec 4, 2023

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Oct 17, 2023 •
edited by cferreiragonz
Loading

cmake 2.8 are deprecated in cmake3.27.
Switch to cmake 3.16.3 (the same cmake used in CMakeLists.txt)

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

@mosfet80
Update GitUtils.cmake
4a24a0a 
cmake 2.8 are deprecated in cmake3.27.
Switch to cmake 3.16.3 (the same cmake used in CMakeLists.txt)
@JLBuenoLopez JLBuenoLopez added this to the v2.11.3 milestone Oct 24, 2023
@cferreiragonz
Copy link
Contributor

@richiprosima please test mac

@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Dec 1, 2023
@cferreiragonz
Copy link
Contributor

@richiprosima please test mac

cferreiragonz
cferreiragonz approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct version of cmake

@EduPonz EduPonz merged commit 41f7627 into eProsima:2.11.x Dec 4, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.11.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mosfet80 @cferreiragonz @EduPonz @JLBuenoLopez